Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

How to stop reset accordion items when i change locale state in this component? #284

Closed
AkhmerovM opened this issue Jul 26, 2020 · 8 comments

Comments

@AkhmerovM
Copy link

Hello everyone, i found a problem, that when i called useState hook, all accordion items has closed.
may be exists key for items, then will not close items when component rerender?

@ge022
Copy link

ge022 commented Jul 27, 2020

Same issue here, and it is occurring since version 3.3.0

@holloway
Copy link

Hi, I'll look at this bug this week.

@InfraK
Copy link

InfraK commented Aug 4, 2020

The issue goes away if you add uuid to the AccordionItem, the key prop used to do the same, but must have changed the behavior in recent versions.

@holloway
Copy link

holloway commented Aug 4, 2020

@InfraK ah thanks for looking into that. I'd started but couldn't reproduce the bug yet.

@holloway
Copy link

holloway commented Aug 6, 2020

#285

@holloway
Copy link

holloway commented Aug 6, 2020

Release v3.3.3 ... can you see if this fixes the issue for you @InfraK @ge022 @AkhmerovM ?

@InfraK
Copy link

InfraK commented Aug 11, 2020

Can confirm is working now @holloway thank you.

@holloway
Copy link

Assuming fixed. Please reopen if you're still having problems.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants