Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ReactDOM.render is no longer supported in React 18. Use createRoot instead. #8

Open
Flammae opened this issue Jun 11, 2022 · 0 comments

Comments

@Flammae
Copy link
Contributor

Flammae commented Jun 11, 2022

Running yarn test on my forked version outputs the error:

Warning: ReactDOM.render is no longer supported in React 18. Use createRoot instead. Until you switch to the new API, your app will behave as if it's running React 17.

I could easily change test cases to work with react 18. I just need some clarifications to avoid overcomplicating the process.

I'm working on two small features which I'm planning to do pull requests on separately. Should I include this bug fix in one of the feature requests or should I make a separate bugfix/react-18-support branch?

Also, which should be more appropriate - raising the issue first, describing the reasoning to why I would like to add such a feature or making a pull request and describing the reasoning there? Furthermore, if you can tell me how I can improve the process compared to last merge request, I will try to take into account in the future.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant