You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Running yarn test on my forked version outputs the error:
Warning: ReactDOM.render is no longer supported in React 18. Use createRoot instead. Until you switch to the new API, your app will behave as if it's running React 17.
I could easily change test cases to work with react 18. I just need some clarifications to avoid overcomplicating the process.
I'm working on two small features which I'm planning to do pull requests on separately. Should I include this bug fix in one of the feature requests or should I make a separate bugfix/react-18-support branch?
Also, which should be more appropriate - raising the issue first, describing the reasoning to why I would like to add such a feature or making a pull request and describing the reasoning there? Furthermore, if you can tell me how I can improve the process compared to last merge request, I will try to take into account in the future.
The text was updated successfully, but these errors were encountered:
Running yarn test on my forked version outputs the error:
I could easily change test cases to work with react 18. I just need some clarifications to avoid overcomplicating the process.
I'm working on two small features which I'm planning to do pull requests on separately. Should I include this bug fix in one of the feature requests or should I make a separate
bugfix/react-18-support
branch?Also, which should be more appropriate - raising the issue first, describing the reasoning to why I would like to add such a feature or making a pull request and describing the reasoning there? Furthermore, if you can tell me how I can improve the process compared to last merge request, I will try to take into account in the future.
The text was updated successfully, but these errors were encountered: