Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: allow for coordinator to be set manually #9

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

feat: allow for coordinator to be set manually #9

wants to merge 2 commits into from

Conversation

mpetrun5
Copy link
Collaborator

@mpetrun5 mpetrun5 commented Feb 3, 2025 •
edited
Loading

Allow for coordinator of a process to be set manually by the caller.
If left empty it would default to choosing the peer by the designated elector.

Description

Related Issue Or Context

Closes: #3

How Has This Been Tested? Testing details.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Documentation

Checklist:

  • I have commented my code, particularly in hard-to-understand areas.
  • I have ensured that all acceptance criteria (or expected behavior) from issue are met
  • I have updated the documentation locally and in docs.
  • I have added tests to cover my changes.
  • I have ensured that all the checks are passing and green, I've signed the CLA bot

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025

Go Test coverage is 54.6 %\ ✨ ✨ ✨

@github-actions GitHub Actions
Copy link

github-actions bot commented Feb 3, 2025

Go Test coverage is 54.6 %\ ✨ ✨ ✨

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MakMuftic MakMuftic MakMuftic approved these changes

@tcar121293 tcar121293 Awaiting requested review from tcar121293 tcar121293 is a code owner

@nmlinaric nmlinaric Awaiting requested review from nmlinaric nmlinaric is a code owner

@freddyli7 freddyli7 Awaiting requested review from freddyli7 freddyli7 is a code owner

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow for coordinator to be set manually
2 participants
@mpetrun5 @MakMuftic