Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Siwe doesn't work on mobile #82

Closed
njxyz opened this issue Mar 21, 2024 · 4 comments
Closed

Siwe doesn't work on mobile #82

njxyz opened this issue Mar 21, 2024 · 4 comments

Comments

@njxyz
Copy link
Contributor

njxyz commented Mar 21, 2024

Have been trying to sign in with wallet to oidc.signinwithethereum.org via mobile phone, with Rainbow and metamask, and it doesn't work:

  1. I click sign in with Ethereum
  2. It redirects me to metamask, where I click connect
  3. When I go back to the app, nothing happens.
@sbihel sbihel transferred this issue from spruceid/siwe Mar 22, 2024
@sbihel
Copy link
Member

sbihel commented Mar 22, 2024

The libraries we use are outdated. In particular @web3modal/ethereum has been deprecated in favour of @web3modal/wagmi. We do not have capacity at the moment to upgrade dependencies and test it -- but we would welcome a PR if someone is keen on contributing.

@njxyz
Copy link
Contributor Author

njxyz commented Mar 22, 2024

@sbihel Thanks for the reply. We can try make a PR, though if it's merged, would you deploy it to the hosted provider? Thanks

@sbihel
Copy link
Member

sbihel commented Mar 22, 2024

Yes I would handle the release and deployment.

@njxyz
Copy link
Contributor Author

njxyz commented Mar 24, 2024

@sbihel Here's the PR with the respective updates: #84

This was tested on web & mobile. Feel free to test it out on your end as well.

@sbihel sbihel closed this as completed in 5f704a6 Mar 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants