Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coveralls shows 0 coverage despite coverage report and runner output looking fine #267

Closed
CAM-Gerlach opened this issue Oct 29, 2021 · 2 comments · Fixed by #268
Closed
Assignees
Labels
Milestone

Comments

@CAM-Gerlach
Copy link
Member

On PR #262 , I verified that the coverage reports and the coveralls output all looked good (after some fixes to get things working), and I can confirm they still do in the latest build. However, @dalthviz noticed that coveralls is showing zero coverage, which I suspect (given the lack of other obvious reasons) is due to it not correctly handling coverage from the installed package (vs. the local source) properly.

In addition, it would be nice if we could submit coverage from all jobs (since they cover different things), unique reports for each binding (instead of just the last one), and title the individual jobs more descriptively so its clear what platform/Python version/install type/binding they came from, though the main priority here is just getting things working again.

@CAM-Gerlach
Copy link
Member Author

Actually, the other possible reason (which occurred on the same commit, so I can't confirm which it was) might be due having to run pytest from inside the qtpy package directory, as a hack to get around some of the problems caused by QtPy not (yet) having the modern best-practice src directory layout (which would be nice to transition to, but that's up to @dalthviz ), meaning that the coverage report gets dumped in that directory and coveralls doesn't find it (and doesn't issue any kind of error or warning). Hopefully that's the case, as if so it should be fairly simple to resolve. I'll test both and figure out what's going on.

@CAM-Gerlach
Copy link
Member Author

Yup, it indeed was the latter, as I'd hoped. In that case, it should be a simple fix and go right along with the other improvements.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant