Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add documentation for methods or helpers that are specific to qtpy #61

Closed
goanpeca opened this issue Aug 16, 2016 · 5 comments · Fixed by #357
Closed

Add documentation for methods or helpers that are specific to qtpy #61

goanpeca opened this issue Aug 16, 2016 · 5 comments · Fixed by #357
Assignees
Milestone

Comments

@goanpeca
Copy link
Member

goanpeca commented Aug 16, 2016

This includes documenting

  • from qtpy.QtCore import Signal, Slot
  • The use of the openfiledialog openfolderdialog helpers (study the option of overloading QFileDialog... which would also need documentation as it would change the default behavior)
  • Where to find the Qt version from qtpy.QtCore import __version__
@Nodd
Copy link
Contributor

Nodd commented Aug 16, 2016

That could be done directly in the readme because it's quite important.

@goanpeca
Copy link
Member Author

Agreed!

@goanpeca
Copy link
Member Author

Ok I will add this to the Readme now based on #76.

@Nodd, we never claimed to be 5.3 or something compatible, I think the aim was to be 5.6+, thoughts?

@goanpeca goanpeca self-assigned this Sep 29, 2016
@goanpeca goanpeca added this to the v1.2 milestone Sep 29, 2016
@ccordoba12 ccordoba12 modified the milestones: v1.2, v1.3 Jan 2, 2017
@ccordoba12 ccordoba12 modified the milestones: v1.3, v1.4 May 8, 2017
@ccordoba12 ccordoba12 modified the milestones: v1.4, v1.5 Mar 11, 2018
@ccordoba12 ccordoba12 modified the milestones: v1.5, v2.0 Jun 11, 2018
@goanpeca goanpeca added the v2.0 label Feb 19, 2020
@goanpeca goanpeca removed this from the v2.0 milestone Feb 19, 2020
@goanpeca goanpeca removed their assignment Aug 22, 2020
@ccordoba12 ccordoba12 added this to the v2.0.0 milestone Aug 10, 2021
@ccordoba12 ccordoba12 removed the v2.0 label Aug 10, 2021
@CAM-Gerlach
Copy link
Member

@dalthviz I can try to help with this, but given I'm not a Qt expert (both a benefit and a downside when writing user docs), I'll need a little more detail on what you want said here:

  • Beyond just letting people know to import Signal and Slot from here, are there QtPy-specific syntax or semantics that need to be described, or something else we want to say?
  • I assume this is related to Get rid of getexistingdirectory and patch QFileDialog? #26 ? Basically, we'd need basic documentation for these QtPy-specific helper functions? Since I'm not familiar with them, beyond just elaborating on the API and anything else the docstrings I'd need some help here with what to say.
  • This seems pretty streightforward

@dalthviz
Copy link
Member

dalthviz commented Nov 5, 2021

Beyond just letting people know to import Signal and Slot from here, are there QtPy-specific syntax or semantics that need to be described, or something else we want to say?

Besides the things described at the OP probably some description for the env variables that QtPy uses (FORCE_QT_API, QT_API) as well as state variables available (PYQT5, PYQT6, PYSIDE2, PYSIDE6, etc) could be nice (also letting clear that we are trying to follow Qt5 layout for things, so for example pyqtSlot -> Slot)

I assume this is related to Get rid of getexistingdirectory and patch QFileDialog? #26 ? Basically, we'd need basic documentation for these QtPy-specific helper functions? Since I'm not familiar with them, beyond just elaborating on the API and anything else the docstrings I'd need some help here with what to say.

Yes, related in the sense that following what is decided there (keeping it as it is, adding aliases to those functions or patching QFileDialog) the documentation should reflect that

@dalthviz dalthviz added this to the v2.1.0 milestone Jan 10, 2022
@dalthviz dalthviz modified the milestones: v2.1.0, v2.1.1 Apr 15, 2022
@dalthviz dalthviz modified the milestones: v2.1.1, v2.2.0 Jun 10, 2022
@dalthviz dalthviz self-assigned this Jul 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants