Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

uic.loadUiType is missing #67

Closed
lschr opened this issue Aug 25, 2016 · 6 comments
Closed

uic.loadUiType is missing #67

lschr opened this issue Aug 25, 2016 · 6 comments
Milestone

Comments

@lschr
Copy link

lschr commented Aug 25, 2016

Prior to 48eecd3, all of uic was imported from PyQt in __init__.py, but now it is only loadUi in uic.py. I understand that there may be an issue with the functions not being present in Pyside. Would it be possible to add something similar to the loadUi implementation?

@ccordoba12 ccordoba12 added this to the v1.2 milestone Aug 25, 2016
@ccordoba12
Copy link
Member

@astrofrog, what do you say?

@Nodd
Copy link
Contributor

Nodd commented Aug 26, 2016

We can import all of uic in pyqt, since some people use qtpy for compatibility with pyqt4 and pyqt5 only. It just need a warning that it's not available in pyside.

@astrofrog
Copy link
Contributor

What @Nodd suggests is fine - I don't have time to work on this, but I agree in principle, provided loadUi itself still works with PyQt and PySide.

@ccordoba12
Copy link
Member

Ok, fine by me too.

@Nodd, could you work on a PR following your own advice? I also don't have time to work on it right now, but it shouldn't take too much time :-)

@lschr
Copy link
Author

lschr commented Sep 20, 2016

I found an implementation of loadUiType for Pyside here: https://gist.github.com/mstuttgart/bc246b25b8e0f7edd743
Could this be integrated in qtpy (if the author permits it and so on)?

@goanpeca
Copy link
Member

This could be useful, but is it feature complete? we would need to add some tests :-p any volunteers? @astrofrog ?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants