Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make plugin depend on Python 3 #154

Closed
jitseniesen opened this issue May 4, 2020 · 1 comment · Fixed by #155
Closed

Make plugin depend on Python 3 #154

jitseniesen opened this issue May 4, 2020 · 1 comment · Fixed by #155
Assignees
@jitseniesen
Labels
type:task v0.4.1

Comments

@jitseniesen
Copy link
Member

The plugin does not work in Python 2 anymore because the nonlocal keyword is used in pytestrunner.py. So I should make the plugin Python 3 only before releasing the next version.

Originally noted in #150 (comment)
@jitseniesen jitseniesen self-assigned this May 4, 2020
@goanpeca
Copy link
Member

goanpeca commented May 4, 2020

@jitseniesen remember to add the check on the check_compatibility method of the plugin

@jitseniesen jitseniesen mentioned this issue May 14, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jitseniesen jitseniesen

Labels
type:task v0.4.1
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

PR: Require Python 3.5 or later jitseniesen/spyder-unittest
2 participants
@goanpeca @jitseniesen