Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use new colors for passed and failed tests #96

Closed
ccordoba12 opened this issue Dec 19, 2017 · 8 comments
Closed

Use new colors for passed and failed tests #96

ccordoba12 opened this issue Dec 19, 2017 · 8 comments
Assignees
Milestone

Comments

@ccordoba12
Copy link
Member

@jitseniesen, I think we could use:

  1. A softer shade of red for failed tests. The current color is too strong for my eyes :-)
  2. A stronger shade of green for passed tests. The current color seems to me too light for me.

@goanpeca, what do you think?

@goanpeca
Copy link
Member

goanpeca commented Dec 19, 2017

Agreed. But we should provide these colors from somewhere in spyder so that each plugin can rely on this.

@goanpeca
Copy link
Member

We could have, danger warning information (at least)

@ccordoba12
Copy link
Member Author

Right. We already have danger and warning colors defined for the find/replace widget (not exposed as global constants though), so we could use them here too.

@goanpeca
Copy link
Member

goanpeca commented Dec 19, 2017

Right. We already have danger and warning colors defined for the find/replace widget (not exposed as global constants though), so we could use them here too.

Yep something like that :-)

Since the idea was to use maybe breeze to define the new theme for spyder, we could base it from that:

From https://community.kde.org/KDE_Visual_Design_Group/HIG/IconDesign
screen shot 2017-12-19 at 16 48 18

@ccordoba12
Copy link
Member Author

Good call! @jitseniesen, what do you think?

@jitseniesen
Copy link
Member

Using the same colour throughout Spyder is obviously a good thing. The colours from breeze look quite okay. I will make some mock-ups and we can see.

@jitseniesen jitseniesen self-assigned this Dec 20, 2017
@jitseniesen jitseniesen added this to the v0.3 milestone Dec 20, 2017
@jitseniesen
Copy link
Member

Currently, the colours are #C1FFBA, #FF0000 and #C5C5C5 (cool how github adds the small colour boxes!). This looks as follows (there are more passing than failing tests, since I expect this to happen in practice):
colour-current

The find/replace widget uses #FF5050 for "regexp error" and #FFAF5A for "pattern not found". This is a paler red. If we use #FF5050 in the unittest widget, it looks as follows:
colour-findreplace

CodeEditor.error_color is used to indicate errors in the panel to the right of the editor and is set to #EA2B0E. This looks like:
colour-scrollflag

The KDE icon colours for Breeze include #DA4453 (icon red) and #2ECC71 (icon green), which looks like:
colour-breeze

Any suggestions? To me the second picture seems perhaps the most readable.

@ccordoba12
Copy link
Member Author

To me the second picture seems perhaps the most readable.

Agreed. I think you should implement that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants