Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make internal console respect user's syntax highlighting theme #8072

Closed
CAM-Gerlach opened this issue Oct 14, 2018 · 1 comment · Fixed by #8251
Closed

Make internal console respect user's syntax highlighting theme #8072

CAM-Gerlach opened this issue Oct 14, 2018 · 1 comment · Fixed by #8251

Comments

@CAM-Gerlach
Copy link
Member

Problem Description

A part of #8068 .

Currently, the Internal Console and the Issue Report dialog use the default Spyder syntax highlighting theme, which wasn't as big of a problem in the past. However, now that Spyder is offering an application-wide dark theme, it looks odd to have these panes in a different color as the rest of the UI. As a stopgap, we could have them default to the Spyder Dark scheme if using the dark UI theme, but if we're going that far and it isn't much more effort, it would seem prudent to just use the proper theme to begin with.

e.g.

image.png

@ccordoba12 ccordoba12 added this to the v4.0beta2 milestone Oct 14, 2018
@ccordoba12 ccordoba12 changed the title Consider making internal console and issue report dialog respect user's syntax highlighting theme Make internal console and issue report dialog respect user's syntax highlighting theme Oct 15, 2018
@ccordoba12 ccordoba12 changed the title Make internal console and issue report dialog respect user's syntax highlighting theme Make internal console respect user's syntax highlighting theme Oct 15, 2018
@ccordoba12
Copy link
Member

ccordoba12 commented Oct 15, 2018

The error dialog stuff (only the description widget though) was fixed in PR #8081. The traceback part and the internal console will be fixed in another PR (they are both related).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants