-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add project preferences #9804
Comments
@dalthviz, did you find the notes I gave you in January for this? |
@ccordoba12 I searched but I didn't find them :/ |
Ok, no worries. I'll try to remember what I was thinking about it. |
@ccordoba12 could you paste the paper here :-) ? thanks! |
I still need to update icons and the actual logic for environments (a separate PR for anaconda-project). Is this what you had in mind @ccordoba12? Environment and packagesFor this one I think the user should only be able to change the package from the last option? A user using the default spyder env or another env should not be able to modify this since these other envs might not be handled by anaconda project at all. Also, how should we signal, conda vs pip ? My idea is to have add create a small dialog where we can validate input and then populate the table. Clicking on the table for edition would pop up this dialog. I think this makes the process easier, since we can validate at the dialog level and not the table level. Thoughts @ccordoba12 ? |
We could also add something related to Where should we include the |
@jnsebgosselin do you have some suggestions for the icons we could use :-) ? |
Yes, this is pretty much what I had in mind! Thanks! About your screenshots:
About your questions:
|
👍
Ok, but I need some extra pointers on how we will handle some things. What packages should we display on the packages tab when:
Yes I think it makes sense for now.
Ok will do. |
I agree this is the crucial point. Without users letting us know a specific set of packages in their environment, it's not possible for us to guarantee project reproducibility. I see two options here:
|
Perhaps both options apply? |
The issue I see with this option (besides adding greater complexity) is that two or more projects could be using this other conda environment so, if the user has different dependencies on different projects, that conda env might reach a point where it will have to update some packages on project switch (because the user selected different "packages" as the main packages of their environment). The only "solution" to this is that a project could only use another existing conda env, but this also probably defeat its purpose for users wanting to recycle the same env for may different projects.
What I think would make sense to me is that if the user select an existing environment, we can display the whole list (as information for the user) but disable any modification of that env from the spyder interface (remove or disable the add/edit/remove). This allows power users that want to recycle envs to use them (they can use the CLI to update the env at their own risk...), but enforces "best practices" for non power users. Thoughts? |
Great point! I haven't thought about that!
Agreed, this is a very good option! Besides, we should show a QLabel with a warning saying that the project is not reproducible. |
Looking good, thanks! My only recommendation (for now) is to remove the QGroupBoxes called "Environment packages" and "Conda environment" because now those are unnecessary with the new tabs. |
@ccordoba12 @goanpeca, it seems to me that there are elements here that we can extract to the Environment Manager plugin #17654. Also, is there any consideration for having multiple projects open at one time? But maybe this is not necessary if IPython consoles are not restarted when switching projects. |
Agreed. We need to discuss further about it though. |
• Environment variables: Aqui debería ir una tabla con las variables de entorno definidas en el proyecto, junto la posibilidad de añadir o eliminar variables
• Packages: Aquí debería verse la lista de paquetes guardados con anaconda-proyect
• Conda Environment: Aquí debería verse el conda env asociado al proyeto, pero de pronto podemos unir esta entrada con Packages
• Master file: Este es el archivo maestro para correr el proyecto (edited)
The text was updated successfully, but these errors were encountered: