Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

autocommit_block not working with future mode #944

Closed
zzzeek opened this issue Oct 4, 2021 · 1 comment
Closed

autocommit_block not working with future mode #944

zzzeek opened this issue Oct 4, 2021 · 1 comment
Labels
bug Something isn't working migration environment

Comments

@zzzeek
Copy link
Member

zzzeek commented Oct 4, 2021

needs to end the transaction

diff --git a/tests/test_postgresql.py b/tests/test_postgresql.py
index b41c383..8175b54 100644
--- a/tests/test_postgresql.py
+++ b/tests/test_postgresql.py
@@ -433,7 +433,9 @@ class PostgresqlOpTest(TestBase):
         context.assert_("ALTER TABLE t1 ALTER COLUMN some_column %s" % text)
 
 
-class PGAutocommitBlockTest(TestBase):
+from sqlalchemy.testing import fixtures
+
+class PGAutocommitBlockTest(fixtures.FutureEngineMixin, TestBase):
     __only_on__ = "postgresql"
     __backend__ = True
@sqla-tester
Copy link
Collaborator

Mike Bayer has proposed a fix for this issue in the master branch:

frame a transaction around autocommit https://gerrit.sqlalchemy.org/c/sqlalchemy/alembic/+/3130

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working migration environment
Projects
None yet
Development

No branches or pull requests

2 participants