running setup.py/2to3 changes unicode() to str() making code invalid

[sqlalchemy-bot]

Migrated issue, originally created by Anonymous

setup.py distributed with mako runs 2to3 by default on systems with python3.

2to3 automatically changes unicode() to str() making some of the places where unicode() appears incorrect.

i.e. filters.py line 59:
unicode(str(x), encoding=key)

is getting changed to:
str(str(x), encoding=key)

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

will take a look, feel free to let me know where else you've seen it / provide patches....

ideally I'd convert Mako to not require 2to3, but we'd need to drop 2.4 support most likely

[sqlalchemy-bot]

Anonymous wrote:

Is py3k branch on your bitbucket alive? I guess that's the best place to put it in as there are places where unicode changes from python 2 to 3 make the code useless (like checking if value is unicode or str, etc).

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

the only active branch for mako is "default". if there's a py3k there, that's back from when it was being ported to python 3.

[sqlalchemy-bot]

Michael Bayer (@zzzeek) wrote:

the current tip is py2k/py3k in place so this is fixed.

[sqlalchemy-bot]

Changes by Michael Bayer (@zzzeek):

• changed status to closed