Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Node 12.x support #35

Open
pkeuter opened this issue Oct 31, 2019 · 5 comments
Open

Node 12.x support #35

pkeuter opened this issue Oct 31, 2019 · 5 comments

Comments

@pkeuter
Copy link

pkeuter commented Oct 31, 2019

Thanks for this very useful library! Since October 21, Node v12 has gone into LTS. Unfortunately, on NPM there are only precompiled binaries for node-sqlanywhere up to v10.

I've tried to build with node 12, but there are quite some differences (like Handle being gone and using context on all conversions). So I can imagine it will take some time to migrate (at least it would for me).

In the mean time I'm trying to migrate to Node v12 myself, but I'm not really sure what the implications are of my changes so if @gperrow-SAP would have a look that would be amazing!

@gperrow-SAP
Copy link
Contributor

I don't work on the node driver anymore but I know the team that does monitors issues here. A node v12 upgrade is at least on the roadmap but I can't speak to scheduling.

@pkeuter
Copy link
Author

pkeuter commented Oct 31, 2019

I've tried to make this work in #36 but I'm not sure if I've done everything correctly. Maybe someone can have a look and give some feedback.

I changed the version to 2.0 because I don't think it will be very backwards-compatible.

@pkeuter
Copy link
Author

pkeuter commented Oct 31, 2019

By the way thanks @gperrow-SAP for the heads up.

@imankurpatel000
Copy link

@gperrow-SAP Is there any update on this? I think @pkeuter has already made a pull request and made changes. Can you please look at it and get it committed asap.

@imankurpatel000
Copy link

@DanCummins-SAP @gperrow-SAP Any update on this? Is there anything else that we can do to help?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants