Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

default the ollama host #22

Closed
codefromthecrypt opened this issue Sep 1, 2024 · 1 comment
Closed

default the ollama host #22

codefromthecrypt opened this issue Sep 1, 2024 · 1 comment

Comments

@codefromthecrypt
Copy link
Contributor

If you choose the ollama provider, but don't give an ENV for the host, you'll receive an error leading to the lookup line like this:

../src/exchange/providers/ollama.py:45: in from_env
    url = os.environ["OLLAMA_HOST"]

I would suggest we default this, like tests do instead, to "http://localhost:11434/". Even if some tools exclusively require passing OLLAMA_HOST, I think we can justify the implicit default due the user already being explicit with the ollama provider config.

If they want to modify the host, they can still via env or any other mechanism we support in the future.

p.s. I'm happy to change this in a PR!

@codefromthecrypt
Copy link
Contributor Author

will be signaling based on OLLAMA_HOST set in #23, so closing this unless someone else cares, in which case I'll re-open

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant