Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Crash when using code obfuscation #2280

Closed
mlilienberg opened this issue Jan 10, 2022 · 3 comments
Closed

Crash when using code obfuscation #2280

mlilienberg opened this issue Jan 10, 2022 · 3 comments

Comments

@mlilienberg
Copy link

Description

My app is crashing when showing Dialog Fragments while R8 is turned on and with latest version 2.8.1.
I think the issue is that curtains dependency does not provide correct proguard rules. curtains.internal.WindowCallbackWrapper is accessing WindowCallbackWrapper from androidx and android.support via reflection. Adding proguard rules to app level solves the issue for me but it would be better if leakcanary or curtains could define those rules.

-keep class androidx.appcompat.view.WindowCallbackWrapper { *; }
-keep class android.support.v7.view.WindowCallbackWrapper { *; }
@pyricau
Copy link
Member

pyricau commented Jan 10, 2022

Thanks. Moving the issue here: square/curtains#32

@pyricau pyricau closed this as completed Jan 10, 2022
@tronku
Copy link

tronku commented Feb 25, 2022

@pyricau when can we expect this to be released?

@pyricau
Copy link
Member

pyricau commented Apr 3, 2022

@tronku no ETA. you can add the rules to your project.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants