Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove most usage of wall clock time from tests #5673

Closed
yschimke opened this issue Dec 31, 2019 · 3 comments
Closed

Remove most usage of wall clock time from tests #5673

yschimke opened this issue Dec 31, 2019 · 3 comments
Labels
enhancement Feature not a bug tests Fix relates to tests not code
Milestone
Backlog

Comments

@yschimke
Copy link
Collaborator

e.g. replace https://github.com/square/okhttp/pull/5672/files

Thread.sleep(250)

With a count down latch, hopefully in a clean repeatable kotlin way e.g. some mini rendezvous design pattern.
@yschimke yschimke added the enhancement Feature not a bug label Dec 31, 2019
@yschimke yschimke mentioned this issue Dec 31, 2019
Merged
@yschimke yschimke added the tests Fix relates to tests not code label Dec 31, 2019
@swankjesse
Copy link
Collaborator

I like using LinkedBlockingDeque for this kind of coordination.

@yschimke
Copy link
Collaborator Author

yschimke commented Jan 5, 2020

Potentially relates to #2134

@swankjesse swankjesse added this to the Backlog milestone Jan 11, 2020
@swankjesse swankjesse mentioned this issue Jan 19, 2020
Closed
@yschimke yschimke mentioned this issue Dec 4, 2021
Closed
@yschimke yschimke mentioned this issue Jul 23, 2022
Closed
@yschimke
Copy link
Collaborator Author

Closing as low priority

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Feature not a bug tests Fix relates to tests not code
Projects
None yet
Milestone
Backlog
Development

No branches or pull requests
2 participants
@swankjesse @yschimke