Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Override TLS mode #8082

Open
yschimke opened this issue Oct 29, 2023 · 0 comments
Open

Override TLS mode #8082

yschimke opened this issue Oct 29, 2023 · 0 comments
Labels
enhancement Feature not a bug

Comments

@yschimke
Copy link
Collaborator

ConnectionSpec.supportsTlsExtensions is deprecated. However it is the only mechanism to stop OkHttp overriding the SSLParameters after a custom sslSocketFactory has made changes.

We should continue to deprecate supportsTlsExtensions, but allow the same functionality via a similar feature, in which OkHttp would expect clients to completely own the configuration of TLS.

See where we use the current flag to avoid setting ALPN

Platform.get().configureTlsExtensions(sslSocket, address.url.host, address.protocols)

and an example of the configuration done

https://github.com/square/okhttp/blob/ff8da5fa0d7735f012105317b03571a776efa4fc/okhttp/src/jvmMain/kotlin/okhttp3/internal/platform/android/Android10SocketAdapter.kt

@yschimke yschimke added the enhancement Feature not a bug label Oct 29, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Feature not a bug
Projects
None yet
Development

No branches or pull requests

1 participant