Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BufferedSink.write(ByteString, offset, byteCount) #651

Merged
merged 1 commit into from
Aug 29, 2019

Conversation

bnorm
Copy link
Collaborator

@bnorm bnorm commented Aug 23, 2019

No description provided.

Copy link
Collaborator

@swankjesse swankjesse left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should these have default values? I suspect that’s difficult due to the overload not having ’em.

@bnorm
Copy link
Collaborator Author

bnorm commented Aug 26, 2019

I opted to keep the public signature like the existing ByteArray methods for consistency. As for the internal write method, I didn't really see a need for default parameters as updating all calling locations was just as trivial.

Happy to add default parameters if that is the long term goal.

@bnorm
Copy link
Collaborator Author

bnorm commented Aug 28, 2019

Should this also get backported to 1.x? I see that getBuffer and company got backported; I can do the same for binary compatibility.

@swankjesse
Copy link
Collaborator

I’m not particularly worried about backporting. Anyone who builds with 2.x should deploy with 2.x. We just wanna make sure that if you build with 1.x you can drop in 2.x without recompiling.

@swankjesse swankjesse merged commit 81ed412 into square:master Aug 29, 2019
@bnorm bnorm deleted the bnorm.0823.write_sub_bytestring branch August 29, 2019 15:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants