Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sometimes picasso 2.3.3 resize inaccuracy. #593

Closed
start141 opened this issue Jul 22, 2014 · 12 comments
Closed

Sometimes picasso 2.3.3 resize inaccuracy. #593

start141 opened this issue Jul 22, 2014 · 12 comments
Milestone

Comments

@start141
Copy link

aef43932-08a3-11e4-9f9a-ea94cbe6d758

Picasso.with(this)
.load(new File(path))
.resize(1440, 1920)
.centerInside()
.into(mTarget);

When I use picasso 2.3.3 load this image, I put some different width and height, sometimes it resize inaccuracy.

I debug some information to you. It look like width and height reversal.

1

4

2

3

I hope you can resolve this problem, thanks!

@dnkoutso dnkoutso added this to the Picasso 2.4 milestone Jul 22, 2014
@start141
Copy link
Author

from network:
qq20140722203750

from sdcard:
qq20140722204136

If Picasso 2.3.3 load this image from network, the orientation is wrong.
but from sdcard, the orientation is right.

@start141
Copy link
Author

author see this issue?

@dnkoutso
Copy link
Collaborator

Yes.

I am not sure if orientation is read appropriately from network. I'll have to check or you can investigate NetworkBitmapHunter is the one decoding for network requests.

@start141
Copy link
Author

I'll be waiting for your achievement, thanks!

ps: I like picasso very much, it use very easy, and powerful.

@dnkoutso
Copy link
Collaborator

dnkoutso commented Aug 4, 2014

From network the exif orientation is not read like on the file system.

@start141
Copy link
Author

start141 commented Aug 4, 2014

Thanks!
What time can resolve this problem?

@senorcris
Copy link

any ideas what could be causing this issue?

@dnkoutso
Copy link
Collaborator

dnkoutso commented Aug 6, 2014

exif rotation is not decoded when the stream is from network, compared to filesystem.

@dnkoutso
Copy link
Collaborator

dnkoutso commented Aug 6, 2014

No timezone you are better off rotating the bitmap yourself using a custom transformation.

@senorcris
Copy link

where is the original rotation information stored? I see for transformation only a bitmap is passed as an argument.

@start141
Copy link
Author

I found a lib metadata-extractor(https://code.google.com/p/metadata-extractor/, you must download the latest code) allow you to read exif data from a Stream, NetworkBitmapHunter can read orientation whit it, I think it maybe useful for this issue.

@dnkoutso
Copy link
Collaborator

Please see this #692

I am closing this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants