Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: packaged distributions. #21

Open
robertdebock opened this issue May 19, 2018 · 11 comments
Open

Feature: packaged distributions. #21

robertdebock opened this issue May 19, 2018 · 11 comments
Labels
enhancement New feature or request help wanted Extra attention is needed

Comments

@robertdebock
Copy link
Contributor

Hi,

Would it be an idea to package sudo-pair into shipable formats such as:

  • binary in a tar.gz
  • rpm
  • deb
  • apk

I'm able to assist in a RPM at least.

In order to have this feature, I think these items are required:

  • A CI/CD pipeline to build packages if you release a new version of sudo-pair. Maybe travis-ci.
  • (RPM) A spec file describing the build process and the installation.
  • (deb) A control-file like the spec file.
  • An artifact store.

I understand it's quite a request, so if I can help you anywhere, please involve me.

Regards, Robert de Bock.

@stouset
Copy link
Collaborator

stouset commented May 20, 2018

I'm open to the plugin itself being packaged for distributions, but some care needs to be done when doing this. To enable it for real, you really need to configure it for your own environment: sudoer and pairer prompts, and /etc/sudo.conf. And those aren't things I think are easy to guess at or do automatically. Still, apt-get install libsudo_pair is tempting, even if there's some extra legwork remaining to actually turn it on.

@robertdebock
Copy link
Contributor Author

Agreed, I guess you want to make it easy to install the plugin itself, to prevent people from needing to built it themselves.
You could include some sample configurations in /usr/share/doc or so.

@stouset
Copy link
Collaborator

stouset commented May 21, 2018

I don't have time for that at the moment, but I'll leave this issue open since it's something I'd like to do. PRs welcome. :)

@stouset stouset added enhancement New feature or request help wanted Extra attention is needed labels May 21, 2018
@robertdebock
Copy link
Contributor Author

I'm working on the RPM build. Should start to work today or tomorrow. When it's working, I'll make a pull request.

@nbraud
Copy link

nbraud commented May 29, 2018

For what it's worth, I just filed an Intent To Package bug in Debian.

@stouset
Copy link
Collaborator

stouset commented May 29, 2018

Thanks!

@stouset
Copy link
Collaborator

stouset commented Mar 13, 2019 via email

@RiotNrrrd
Copy link

Is this thing sudo_pair or sudo-pair? Please pick one or the other and stick with it, it's very confusing.

@stouset
Copy link
Collaborator

stouset commented Jul 1, 2020

As far as I'm aware, every mention of the project is sudo_pair. If there's somewhere it's not, please let me know.

@RiotNrrrd
Copy link

As far as I'm aware, every mention of the project is sudo_pair. If there's somewhere it's not, please let me know.

It's in contrib/sudo-pair.spec.

[mockbuild@vm-rh7 SOURCES]$ tar -tzpf sudo_pair-v0.11.1.tar.gz | grep sudo-pair
sudo_pair-sudo_pair-v0.11.1/contrib/sudo-pair.spec

[mockbuild@vm-rh7 SOURCES]$ tar -xzpf sudo_pair-v0.11.1.tar.gz

[mockbuild@vm-rh7 SOURCES]$ find sudo_pair-sudo_pair-v0.11.1 -type f -print0 | xargs -0 egrep -l sudo-pair
sudo_pair-sudo_pair-v0.11.1/contrib/sudo-pair.spec

[mockbuild@vm-rh7 SOURCES]$ grep sudo-pair sudo_pair-sudo_pair-v0.11.1/contrib/sudo-pair.spec
Name: sudo-pair

@robertdebock
Copy link
Contributor Author

As far as I'm aware, every mention of the project is sudo_pair. If there's somewhere it's not, please let me know.

It's in contrib/sudo-pair.spec.

[mockbuild@vm-rh7 SOURCES]$ tar -tzpf sudo_pair-v0.11.1.tar.gz | grep sudo-pair
sudo_pair-sudo_pair-v0.11.1/contrib/sudo-pair.spec

[mockbuild@vm-rh7 SOURCES]$ tar -xzpf sudo_pair-v0.11.1.tar.gz

[mockbuild@vm-rh7 SOURCES]$ find sudo_pair-sudo_pair-v0.11.1 -type f -print0 | xargs -0 egrep -l sudo-pair
sudo_pair-sudo_pair-v0.11.1/contrib/sudo-pair.spec

[mockbuild@vm-rh7 SOURCES]$ grep sudo-pair sudo_pair-sudo_pair-v0.11.1/contrib/sudo-pair.spec
Name: sudo-pair

That's something I can fix, I'll make a PR for it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests

4 participants