Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make the sample code use kotlinx.serialization for snapshotting chores. #34

Closed
rjrjr opened this issue Dec 3, 2018 · 5 comments
Closed

Make the sample code use kotlinx.serialization for snapshotting chores. #34

rjrjr opened this issue Dec 3, 2018 · 5 comments
Labels
blocked kotlin Affects the Kotlin library. points: 1
Milestone
post-v1.0.0

Comments

@rjrjr
Copy link
Contributor

rjrjr commented Dec 3, 2018 •
edited
Loading

Should work, but let's prove it.
@rjrjr rjrjr added the points: 1 label Dec 3, 2018
@rjrjr rjrjr added this to the Stabilize API milestone Dec 3, 2018
@rjrjr rjrjr added the blocked label Dec 3, 2018
@rjrjr
Copy link
Contributor Author

rjrjr commented Dec 3, 2018

Blocked by #35

@rjrjr rjrjr changed the title Drop Snapshot, use Kotlin serialization Better Snapshot support Feb 13, 2019
@zach-klippenstein zach-klippenstein changed the title Better Snapshot support Better support for serializing sealed/data classes to Snapshots. Mar 31, 2019
@zach-klippenstein zach-klippenstein modified the milestones: Cross-platform API Convergence, v1.0.0 Mar 31, 2019
@zach-klippenstein
Copy link
Collaborator

zach-klippenstein commented Apr 24, 2019 •
edited
Loading

We can't do anything about this until we are using a build system internally that actually works with either reflection or compiler plugins, which we don't have a timeline for. Moving to post-v1.0 backlog.

@zach-klippenstein zach-klippenstein modified the milestones: v1.0.0, Post-v1.0 Apr 24, 2019
@zach-klippenstein
Copy link
Collaborator

I think we can close this. Parcelize/kotlinx.serialization are good enough. WDYT @rjrjr?

@rjrjr
Copy link
Contributor Author

rjrjr commented Sep 16, 2019

I'll re-purpose this ticket to at least write a sample using kotlinx.serialization.

@rjrjr rjrjr changed the title Better support for serializing sealed/data classes to Snapshots. Make the sample code use kotlinx.serialization for snapshotting chores. Sep 16, 2019
@JustinDSN JustinDSN added the kotlin Affects the Kotlin library. label Feb 27, 2020
@zach-klippenstein zach-klippenstein modified the milestones: v1.0.0, post-v1.0.0 Jun 13, 2020
@rjrjr
Copy link
Contributor Author

rjrjr commented May 4, 2022

Yeah no.

@rjrjr rjrjr closed this as completed May 4, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
blocked kotlin Affects the Kotlin library. points: 1
Projects
None yet
Milestone
post-v1.0.0
Development

No branches or pull requests
3 participants
@zach-klippenstein @JustinDSN @rjrjr