Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

AppleCore doesn't trigger an error when used with the wrong MC version #84

Closed
Syndaryl opened this issue Feb 3, 2017 · 8 comments
Closed

Comments

@Syndaryl
Copy link

Syndaryl commented Feb 3, 2017

Which is causing errors and threatening messages in the Forge log...

@GirafiStudios
Copy link
Collaborator

GirafiStudios commented Feb 3, 2017

Well first of all Apple Core is not released for 1.11.2 just yet.
And yes Apple Cores ID for 1.11.2 is lowercased https://github.com/squeek502/AppleCore/blob/1.11.2/java/squeek/applecore/ModInfo.java#L5.

@Syndaryl
Copy link
Author

Syndaryl commented Feb 3, 2017

OK, I'm a little confused since I got it off Curseforge yesterday (along with Appleskin). Looking at the JAR again it's the 1.10.2 not 1.11.2 - but I have no idea why forge wouldn't just reject it for being the wrong version entirely. shrug Oh well, sorry for bothering you.

@squeek502
Copy link
Owner

Yeah, it might be a good idea for us to use acceptedMinecraftVersions to make Forge trigger an error on incompatible MC versions. Even weirder is that the core mod part of AppleCore is locked to the MC version and definitely wouldn't have loaded if you tried to use the 1.10.2 version with 1.11.2.

Re-opening for now, will close again when acceptedMinecraftVersions gets set.

@squeek502 squeek502 reopened this Feb 3, 2017
@squeek502 squeek502 changed the title Applecore name is not lowercased for 1.11.2 AppleCore doesn't trigger an error when used with the wrong MC version Feb 3, 2017
@Syndaryl
Copy link
Author

Syndaryl commented Feb 3, 2017

Sounds good for me.

@squeek502
Copy link
Owner

Also worth mentioning just in case you weren't aware that AppleSkin doesn't depend on AppleCore, it's completely standalone.

@Syndaryl
Copy link
Author

Syndaryl commented Feb 4, 2017

I didn't realize that yesterday, but I put two and two together finally today :)

@squeek502
Copy link
Owner

@Syndaryl released an actual 1.11.2 version as well: https://minecraft.curseforge.com/projects/applecore/files/2378384

@Syndaryl
Copy link
Author

Syndaryl commented Feb 6, 2017

Most excellent!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants