codestyle for binary checking

Author: dopefishh

antifmt.sh

@@ -16,10 +16,8 @@ if [ -z "$*" ]; then
 	exit 1
 fi
 
-for cmd in unzip unrar 7zr bunzip2 gunzip unxz tar pdftotext
-do
-	if ! command -v $cmd >/dev/null 2>&1
-	then
+for cmd in unzip unrar 7zr bunzip2 gunzip unxz tar pdftotext; do
+	if ! command -v $cmd >/dev/null 2>&1; then
 		echo "Who am I? Why am I here? Am I on lilo? $cmd is missing!" >& 2
 		exit 1
 	fi

bsunzip.sh

@@ -2,10 +2,8 @@
 
 # unzip a brightspace-provided file, and split the index.html it contains over the subdirectories
 
-for cmd in unzip iconv
-do
-	if ! command -v $cmd >/dev/null 2>&1
-	then
+for cmd in unzip iconv; do
+	if ! command -v $cmd >/dev/null 2>&1; then
 		echo "Who am I? Why am I here? Am I on lilo? $cmd is missing!" >& 2
 		exit 1
 	fi

collectplag.sh

@@ -14,14 +14,10 @@
 # ./antifmt.sh
 # ./groepjes.sh [ufsez][0-9]*
 
-for cmd in tar
-do
-	if ! command -v $cmd >/dev/null 2>&1
-	then
-		echo "Who am I? Why am I here? Am I on lilo? $cmd is missing!" >& 2
-		exit 1
-	fi
-done
+if ! command -v tar >/dev/null 2>&1; then
+	echo "Who am I? Why am I here? Am I on lilo? tar is missing!" >& 2
+	exit 1
+fi
 
 dir="plag"
 for arg in "$@"; do

iching.sh

@@ -1,13 +1,9 @@
 #! /bin/bash
 
-for cmd in curl
-do
-	if ! command -v $cmd >/dev/null 2>&1
-	then
-		echo "Who am I? Why am I here? Am I on lilo? $cmd is missing!" >& 2
-		exit 1
-	fi
-done
+if ! command -v curl >/dev/null 2>&1; then
+	echo "Who am I? Why am I here? Am I on lilo? curl is missing!" >& 2
+	exit 1
+fi
 
 url="http://www.thateden.co.uk/dirk/pred.php?ching1=$(($RANDOM%8+1))&ching2=$(($RANDOM%8+1))"
 

identify.sh

@@ -3,14 +3,10 @@
 # this script adds email addresses and student ids to folder names extracted
 # from Brightspace, given a CSV file obtained via 'Enter Grades'
 
-for cmd in curl
-do
-	if ! command -v $cmd >/dev/null 2>&1
-	then
-		echo "Who am I? Why am I here? Am I on lilo? $cmd is missing!" >& 2
-		exit 1
-	fi
-done
+if ! command -v curl >/dev/null 2>&1; then
+	echo "Who am I? Why am I here? Am I on lilo? curl is missing!" >& 2
+	exit 1
+fi
 
 if [ -z "$1" ]; then
         echo "Usage: addraddr.sh spreadsheet.csv [dir1] [dir2] ... [dirN]" 1>&2

jarify.sh

@@ -3,10 +3,8 @@
 # convert a flat directory into a jar file
 # - when run without arguments, convert the current directory
 # - when run with argument, convert every mentioned directory
-for cmd in jar javac
-do
-	if ! command -v $cmd >/dev/null 2>&1
-	then
+for cmd in jar javac; do
+	if ! command -v $cmd >/dev/null 2>&1; then
 		echo "Who am I? Why am I here? Am I on lilo? $cmd is missing!" >& 2
 		exit 1
 	fi

mailto.sh

@@ -2,10 +2,8 @@
 
 # this sends the message in dir/file.txt to the addresses in dir/#address.txt
 
-for cmd in bsd-mailx iconv
-do
-	if ! command -v $cmd >/dev/null 2>&1
-	then
+for cmd in bsd-mailx iconv; do
+	if ! command -v $cmd >/dev/null 2>&1; then
 		echo "Who am I? Why am I here? Am I on lilo? $cmd is missing!" >& 2
 		exit 1
 	fi

rgrade.sh

@@ -2,10 +2,8 @@
 
 # Start grading in a randomly chosen, ungraded submission folder
 
-for cmd in base64 gunzip
-do
-	if ! command -v $cmd >/dev/null 2>&1
-	then
+for cmd in base64 gunzip; do
+	if ! command -v $cmd >/dev/null 2>&1; then
 		echo "Who am I? Why am I here? Am I on lilo? $cmd is missing!" >& 2
 		exit 1
 	fi

trialc.sh

@@ -1,13 +1,9 @@
 #! /bin/sh
 
-for cmd in g++
-do
-	if ! command -v $cmd >/dev/null 2>&1
-	then
-		echo "Who am I? Why am I here? Am I on lilo? $cmd is missing!" >& 2
-		exit 1
-	fi
-done
+if ! command -v g++ >/dev/null 2>&1; then
+	echo "Who am I? Why am I here? Am I on lilo? g++ is missing!" >& 2
+	exit 1
+fi
 
 if [ -z "$1" ]; then
 	echo "usage: trialc.sh dir" 1>&2

verdeel.sh

@@ -22,10 +22,8 @@ SUBJECT="`whoami` could not be bothered to configure SUBJECT"
 # this script takes care of the distribution of workload over
 # all the teaching assistants, after downloading the zip
 
-for cmd in 7za mutt
-do
-	if ! command -v $cmd >/dev/null 2>&1
-	then
+for cmd in 7za mutt; do
+	if ! command -v $cmd >/dev/null 2>&1; then
 		echo "Who am I? Why am I here? Am I on lilo? $cmd is missing!" >& 2
 		exit 1
 	fi

wizard.sh

@@ -22,14 +22,10 @@ exit
 
 # configuration wizard for bb-scripts
 
-for cmd in curl
-do
-	if ! command -v $cmd >/dev/null 2>&1
-	then
-		echo "Who am I? Why am I here? Am I on lilo? $cmd is missing!" >& 2
-		exit 1
-	fi
-done
+if ! command -v curl >/dev/null 2>&1; then
+	echo "Who am I? Why am I here? Am I on lilo? curl is missing!" >& 2
+	exit 1
+fi
 
 set -e
 cd "${0%/*}"