-
-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Unable to build 9.5.3-insiders-4.49.1
with tags
plugin on Netlify (Python 3.8)
#6627
Comments
fyi @shepherdjerred the last insiders tag before this breaking change was |
Thanks for reporting! We're definitely interested in supporting Python 3.8, so this is an oversight on our side. It should be fixed with I'm quite amazed to read that Netlify isn't doing anything to support newer Python versions. Are there maybe alternative platforms that could be used? |
Thanks for such a quick fix!
It's pretty embarrassing that Netlify hasn't updated their supported Python versions. We only use Netlify for deploy previews since it's so convenient and already setup. I'm sure there are alternatives, but we just haven't prioritized it. |
I tried with the latest commit on master (https://github.com/squidfunk/mkdocs-material-insiders/commit/8721121c2ce4151d86fe868d5f8c9ca7257b9708) I now see this error:
I'm not sure if this is just an issue with tags on Python 3.8, or if it's something more specific. I can provide a full reproduction if you'd like. |
Fixed in |
Any idea when we can expect a release? 🙂 |
As soon as we know that all issues are fixed. My testing shows that the latest commit fixes all issues with Python 3.8. If you can confirm that I can push out a release in 15min. |
Okay, I went ahead and released the changes because I'm quite confident that this should be fixed. Sorry for the inconvenience, but I'm happy that we could resolve it in half a day. Released as part of 9.5.3+insiders-4.49.2. |
I can confirm that our build (also on Python 3.8) no longer fails when installing from the commit you mentioned. Thanks! |
That worked for me. Thanks again for fixing this so quickly. |
Context
No response
Bug description
9.5.3-insiders-4.49.1
with thetags
plugin does not build on Python 3.8:Union types were added in Python 3.10, but Netlify only supports Python 3.8. Netlify does not plan to support newer versions.
Related links
Reproduction
mkdocs.zip
Steps to reproduce
9.5.3-insiders-4.49.1
tags
pluginmkdocs build
Browser
No response
Before submitting
The text was updated successfully, but these errors were encountered: