Fixed bug #2663 : Generic.NamingConventions.ConstructorName complains…

… about old constructor in interfaces
squizlabs · Oct 24, 2019 · 35256b6 · 35256b6
1 parent e7b0cce
commit 35256b6
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 2 deletions.
diff --git a/package.xml b/package.xml
@@ -37,6 +37,7 @@ http://pear.php.net/dtd/package-2.0.xsd">
   - Fixed bug #2654 : Incorrect indentation for arguments of multiline function calls
   - Fixed bug #2656 : Squiz.WhiteSpace.MemberVarSpacing removes comments before first member var during auto fixing
     -- Thanks to Juliette Reinders Folmer for the patch
+  - Fixed bug #2663 : Generic.NamingConventions.ConstructorName complains about old constructor in interfaces
   - Fixed bug #2664 : PSR12.Files.OpenTag incorrectly identifies PHP file with only an opening tag
  </notes>
  <contents>

diff --git a/src/Standards/Generic/Sniffs/NamingConventions/ConstructorNameSniff.php b/src/Standards/Generic/Sniffs/NamingConventions/ConstructorNameSniff.php
@@ -39,7 +39,7 @@ class ConstructorNameSniff extends AbstractScopeSniff
      */
     public function __construct()
     {
-        parent::__construct([T_CLASS, T_ANON_CLASS, T_INTERFACE], [T_FUNCTION], true);
+        parent::__construct([T_CLASS, T_ANON_CLASS], [T_FUNCTION], true);
 
     }//end __construct()
 

diff --git a/src/Standards/Generic/Tests/NamingConventions/ConstructorNameUnitTest.inc b/src/Standards/Generic/Tests/NamingConventions/ConstructorNameUnitTest.inc
@@ -84,9 +84,14 @@ class Nested extends Another {
 
             public function __construct() {
                 parent::Another(); // OK.
-			}
+            }
         };
     }
 
     abstract public function nested();
 }
+
+interface CustomChildCreator
+{
+    public function customChildCreator($elementName, Project $project);
+}