Added checking for syntax errors

squizlabs · Sep 26, 2019 · 99d6757 · 99d6757
1 parent cf655b4
commit 99d6757
Show file tree

Hide file tree

Showing 2 changed files with 13 additions and 0 deletions.
diff --git a/src/Files/File.php b/src/Files/File.php
@@ -1321,9 +1321,19 @@ public function getMethodParameters($stackPtr)
                 throw new RuntimeException('$stackPtr was not a valid T_USE');
             }
         } else {
+            if (isset($this->tokens[$stackPtr]['parenthesis_opener']) === false) {
+                // Live coding or syntax error, so no params to find.
+                return [];
+            }
+
             $opener = $this->tokens[$stackPtr]['parenthesis_opener'];
         }
 
+        if (isset($this->tokens[$opener]['parenthesis_closer']) === false) {
+            // Live coding or syntax error, so no params to find.
+            return [];
+        }
+
         $closer = $this->tokens[$opener]['parenthesis_closer'];
 
         $vars            = [];

diff --git a/src/Standards/PEAR/Tests/Functions/ValidDefaultValueUnitTest.inc b/src/Standards/PEAR/Tests/Functions/ValidDefaultValueUnitTest.inc
@@ -97,3 +97,6 @@ $closure = function ($arg1, $arg2='hello') {};
 
 // Invalid closure
 $closure = function(array $arg2=array(), array $arg1) {}
+
+// Intentional syntax error. Must be last thing in the file.
+function