Fixed bug #2702 : Generic.WhiteSpace.ScopeIndent false positive when …

…using ternary operator with short arrays The first token was being recalculated but the indent was not being modified along with that new first token.
squizlabs · Nov 18, 2019 · eb378ac · eb378ac
1 parent c120776
commit eb378ac
Show file tree

Hide file tree

Showing 7 changed files with 35 additions and 10 deletions.
diff --git a/package.xml b/package.xml
@@ -66,6 +66,7 @@ http://pear.php.net/dtd/package-2.0.xsd">
     -- Thanks to Juliette Reinders Folmer for the patch
   - Fixed bug #2694 : AbstractArraySniff produces invalid indices when using ternary operator
     -- Thanks to Michał Bundyra for the patch
+  - Fixed bug #2702 : Generic.WhiteSpace.ScopeIndent false positive when using ternary operator with short arrays
  </notes>
  <contents>
   <dir name="/">

diff --git a/src/Standards/Generic/Sniffs/WhiteSpace/ScopeIndentSniff.php b/src/Standards/Generic/Sniffs/WhiteSpace/ScopeIndentSniff.php
@@ -483,12 +483,7 @@ public function process(File $phpcsFile, $stackPtr)
 
                 $arrayOpener = $tokens[$arrayCloser]['bracket_opener'];
                 if ($tokens[$arrayCloser]['line'] !== $tokens[$arrayOpener]['line']) {
-                    $first       = $phpcsFile->findFirstOnLine(T_WHITESPACE, $arrayOpener, true);
-                    $checkIndent = ($tokens[$first]['column'] - 1);
-                    if (isset($adjustments[$first]) === true) {
-                        $checkIndent += $adjustments[$first];
-                    }
-
+                    $first = $phpcsFile->findFirstOnLine(T_WHITESPACE, $arrayOpener, true);
                     $exact = false;
 
                     if ($this->debug === true) {
@@ -524,6 +519,11 @@ public function process(File $phpcsFile, $stackPtr)
                         $first = $phpcsFile->findNext(T_WHITESPACE, ($first + 1), null, true);
                     }
 
+                    $checkIndent = ($tokens[$first]['column'] - 1);
+                    if (isset($adjustments[$first]) === true) {
+                        $checkIndent += $adjustments[$first];
+                    }
+
                     if (isset($tokens[$first]['scope_closer']) === true
                         && $tokens[$first]['scope_closer'] === $first
                     ) {

diff --git a/src/Standards/Generic/Tests/WhiteSpace/ScopeIndentUnitTest.1.inc b/src/Standards/Generic/Tests/WhiteSpace/ScopeIndentUnitTest.1.inc
@@ -1439,6 +1439,12 @@ $result = array_map(
     $numbers
 );
 
+$a = $a === true ? [
+    'a' => 1,
+    ] : [
+    'a' => 100,
+];
+
 ?>
 
      <?php if (true) : ?>

diff --git a/src/Standards/Generic/Tests/WhiteSpace/ScopeIndentUnitTest.1.inc.fixed b/src/Standards/Generic/Tests/WhiteSpace/ScopeIndentUnitTest.1.inc.fixed
@@ -1439,6 +1439,12 @@ $result = array_map(
     $numbers
 );
 
+$a = $a === true ? [
+    'a' => 1,
+    ] : [
+    'a' => 100,
+];
+
 ?>
 
      <?php if (true) : ?>

diff --git a/src/Standards/Generic/Tests/WhiteSpace/ScopeIndentUnitTest.2.inc b/src/Standards/Generic/Tests/WhiteSpace/ScopeIndentUnitTest.2.inc
@@ -1439,6 +1439,12 @@ $result = array_map(
 	$numbers
 );
 
+$a = $a === true ? [
+	'a' => 1,
+	] : [
+	'a' => 100,
+];
+
 ?>
 
 	 <?php if (true) : ?>

diff --git a/src/Standards/Generic/Tests/WhiteSpace/ScopeIndentUnitTest.2.inc.fixed b/src/Standards/Generic/Tests/WhiteSpace/ScopeIndentUnitTest.2.inc.fixed
@@ -1439,6 +1439,12 @@ $result = array_map(
 	$numbers
 );
 
+$a = $a === true ? [
+	'a' => 1,
+	] : [
+	'a' => 100,
+];
+
 ?>
 
 	 <?php if (true) : ?>

diff --git a/src/Standards/Generic/Tests/WhiteSpace/ScopeIndentUnitTest.php b/src/Standards/Generic/Tests/WhiteSpace/ScopeIndentUnitTest.php
@@ -178,10 +178,10 @@ public function getErrorList($testFile='ScopeIndentUnitTest.inc')
             1340 => 1,
             1342 => 1,
             1345 => 1,
-            1449 => 1,
-            1450 => 1,
-            1451 => 1,
-            1452 => 1,
+            1455 => 1,
+            1456 => 1,
+            1457 => 1,
+            1458 => 1,
         ];
 
     }//end getErrorList()