Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Excluded files still have significant performance impact #1132

Closed
Rarst opened this issue Aug 26, 2016 · 1 comment
Closed

Excluded files still have significant performance impact #1132

Rarst opened this issue Aug 26, 2016 · 1 comment

Comments

@Rarst
Copy link

Rarst commented Aug 26, 2016

I work on a project with a lot of node dependencies for its JS side. While we exclude node_modules from CS scan, its presence seems to significantly bog down performance, even though nothing inside of it is actually scanned.

I get time of 2+ minutes for scan, which goes down to 10 seconds if I delete node_modules.

Ruleset & project: https://github.com/Yoast/wordpress-seo/blob/trunk/phpcs.xml (PHPCS and rules in Composer dependencies, run composer config-yoastcs for self–contained setup).

@gsherwood
Copy link
Member

Closing this as a duplicate of #933, and #1113.

Summary: this has been resolved in the 3.0 branch (current release there is 3.0.0a1 if you want to test) but is not being brought to the 2.x branch.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants