Syntax errors not being shown when error_prepend_string is set #1260
Conversation
| @@ -74,11 +74,11 @@ public function process(PHP_CodeSniffer_File $phpcsFile, $stackPtr) | |||
| } | |||
|
|
|||
| $fileName = $phpcsFile->getFilename(); | |||
| $cmd = $this->_phpPath." -l \"$fileName\" 2>&1"; | |||
| $cmd = $this->_phpPath." -l -d error_prepend_string='' \"$fileName\" 2>&1"; | |||
There was a problem hiding this comment.
You can clear the error_append_string as well while you're at it.
There was a problem hiding this comment.
The error_append_string won't cause any issues for this sniff as the regex does not use the $ for end of string/line. (which is why I didn't bother clearing it)
There was a problem hiding this comment.
In that case I would rather change regex to figure out where errors are (instead of changing php.ini settings) in the text instead of matching from text start. That would be more error prone.
For example the on line ([0-9]+) part of regex uniquely identifies the error. This way we don't care where we find it and know for 100% that error text comes before it.
There was a problem hiding this comment.
The added m in the regex already makes it less error prone as it will match the ^ in the regex for start of line instead of start of string, so it will match as soon as it finds a line which contains a (parse) error message ;-)
That's what I meant by making "double sure" 😍
jrfnl
force-pushed
the
feature/fix-php-syntax-sniff
branch
2 times, most recently
from
b88befa
to
32afa3a
Compare
Toggles the command for HHVM which does not have the `error_prepend_string` ini setting.
gsherwood
changed the title
error_prepend_string was set.
|
Thanks a lot for fixing this. |
|
You're very welcome ;-) |
Syntax errors were not being matched if the
php.inifile used contained a value forerror_prepend_string.This fix makes double sure that those will now start showing up as it:
error_prepend_stringwill normally be on its own line in the output, so matching the error pattern for each line should prevent further issues.Unit testing this would be near impossible as one would need to overload the
php.inifile used by the linting process.All the same, the issue can easily be reproduced:
php.inifile for the PHP version on which PHPCS is running, uncomment it and give it a value. Example often used by people mainly using PHP in the browser:<span style='color: #ff0000'>(combined witherror_append_string = "</span>").[Edit]: Recommitted to fix HHVM build failure.