-
Notifications
You must be signed in to change notification settings - Fork 1.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Progress should be written to stderr #1612
Comments
@gsherwood I did make a PR for this which was rejected. Ive seen there is a tag of PHPCS v3 now, Shall I just raise the PR again ? |
This isn't high on the list of things to look into, so I'd suggest not sending one in. I know I wont get around to reviewing it either. |
What @exussum12 says does actually make a lot of sense to me. Would be nice to keep it on the "wish list". |
All status, debug, and progress output is now being written to STDERR, as of d4f33db |
Postix standards suggest the following
https://en.wikipedia.org/wiki/Standard_streams#Standard_error_.28stderr.29
Symphony console, phpstan etc all follow this (other language tools such as webpack also follow this standard)
#1606
Was made to correct this and separate the progress output.
This would keep the same behavior in the following use cases
stderr and stdout are displayed together on a terminal, so it would not matter which is written to.
it would break it in the following case
phpcs -p src > savedOutput.txt
as saved output would now not contain the progress output.
This would make the
--report-full=
option function the same as>
which is a much more standard way of handling output optionsand improve the following
phpcs -p src | grep something
as the progress would now be printed and not sent to the pipe
The text was updated successfully, but these errors were encountered: