Squiz.CSS.EmptyStyleDefinition sees comment as style definition and fails to report error #1737
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `Squiz.CSS.EmptyStyleDefinition` sniff checks for CSS styles being defined without value. This sniff would fail to report an issue if there is no value, but a comment is encountered instead. Includes unit tests.
jrfnl
force-pushed
the
feature/squiz-css-emptystyle-allow-for-comments
branch
from
97abfad
to
fbb04ca
Compare
|
Rebased for merge conflicts & updated code style... |
gsherwood
changed the title
|
Thanks for this fix |
|
You're welcome ;-) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Squiz.CSS.EmptyStyleDefinitionsniff checks for CSS styles being defined without value.This sniff would fail to report an issue if there is no value, but a comment is encountered instead.
Includes unit tests.