File::getMemberProperties() is recognizing method params as properties #2214
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Method parameters were recognized as if they were class properties. Looks like I already included an initial unit test case for this in 1715, but that case was not being tested. The change in this PR should fix the issue and activates the existing unit test and adds some extra as well.
jrfnl
force-pushed
the
feature/file-getmemberproperties-bugfix
branch
from
e7d4774 to
a51d646
Compare
gsherwood
changed the title
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Method parameters were recognized as if they were class properties.
Looks like I already included an initial unit test case for this in #1715, but that case was not being tested.
The change in this PR should fix the issue, activates the existing unit test and adds some extra as well.