Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Default env variables mix binding IP addr with public URL #168

Open
carlosms opened this issue Feb 26, 2018 · 5 comments
Open

Default env variables mix binding IP addr with public URL #168

carlosms opened this issue Feb 26, 2018 · 5 comments
Labels
bug Something isn't working

Comments

@carlosms
Copy link
Contributor

If the default env variables are used, then:
CAT_HOST = 0.0.0.0
CAT_PORT = 8080
CAT_SERVER_URL = <CAT_HOST>:<CAT_PORT>
CAT_UI_DOMAIN = <CAT_HOST>:<CAT_PORT>

With these default values, after a login the browser will try to access 0.0.0.0:8080, and fail.

@carlosms carlosms added the bug Something isn't working label Feb 26, 2018
@dpordomingo dpordomingo added the wontfix This will not be worked on label Mar 9, 2018
@dpordomingo
Copy link
Contributor

I think it no longer happens since #142
Feel free to reopen if I missed something

@carlosms
Copy link
Contributor Author

I doesn't happen for login, but I think the problem is still the same for any other API call, isn't it? The clients will try to access 0.0.0.0:8080.

@dpordomingo dpordomingo reopened this Mar 14, 2018
@dpordomingo dpordomingo removed the wontfix This will not be worked on label Mar 14, 2018
@bzz
Copy link
Contributor

bzz commented Apr 10, 2018

Could you help understand how often does this happen and who is affected by this?

@carlosms
Copy link
Contributor Author

This would only affect an installation where you leave the env. variables unset. For our deployment this is not a problem since we set the env. variables, and this would probably be the expected case in most installations.

@dpordomingo
Copy link
Contributor

It affects in development.
I have a fix for it in a branch to improve dev experience, that I'll resume once we start working on CAT again :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants