Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[proposal] UDF to classify licenses #488

Open
vmarkovtsev opened this issue Sep 23, 2018 · 9 comments
Open

[proposal] UDF to classify licenses #488

vmarkovtsev opened this issue Sep 23, 2018 · 9 comments
Labels

Comments

@vmarkovtsev
Copy link
Contributor

vmarkovtsev commented Sep 23, 2018

This proposes to add a UDF based on go-license-detector to classify licenses of repositories to gitbase core. That UDF requires all the files in HEAD belonging to a repository.

cc @mcuadros @campoy

@campoy
Copy link
Contributor

campoy commented Oct 11, 2018

I'm not sure about this, what's the use case?

@vmarkovtsev
Copy link
Contributor Author

@campoy The use case is to classify the licenses. Wdym?

@campoy
Copy link
Contributor

campoy commented Oct 15, 2018

I wouldn't want to add extra features that do not have a specific persona / use case in mind.
There's many useful things we could add to the engine, we need to ensure that those added have enough value to compensate for the extra API / documentation, etc.

@ajnavarro
Copy link
Contributor

If that functionality requires all the HEAD files from a repository cannot be implemented using a UDF.

A UDF is working at the row level. You can process from 0 to N fields from a row, and generate a new value from that.

@vmarkovtsev
Copy link
Contributor Author

It can work at the row level analyzing one file at a time @ajnavarro

@vmarkovtsev
Copy link
Contributor Author

vmarkovtsev commented Oct 16, 2018

@campoy Regarding the functions. License audit is one of those nasty problems everybody hates to do in the enterprises yet many have to do (and pay for it).

@vmarkovtsev
Copy link
Contributor Author

FWIW tagging @marnovo as he is supposed to decide on the product features.

@erizocosmico
Copy link
Contributor

@ajnavarro what shall we do with this?

@ajnavarro
Copy link
Contributor

If it is just implementing a library, we can create a function like LICENSE(repository_id)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

5 participants