Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Make gitcollector fail if metric could not be updated #60

Open
dpordomingo opened this issue Jul 12, 2019 · 0 comments
Open

Make gitcollector fail if metric could not be updated #60

dpordomingo opened this issue Jul 12, 2019 · 0 comments

Comments

@dpordomingo
Copy link
Contributor

dpordomingo commented Jul 12, 2019 •
edited
Loading

caused by https://github.com/src-d/backlog/issues/1442

Since source{d} CE expects a homogeneous way to import repos and metadata between ghsync and gitcollector, and status is something needed to let the user know about the progress of the process, gitcollector should fail if the progress status could not be updated.

If I'm not wrong, if gitcollector cannot persist the metric, it just logs a warn and it continues the importation metrics/metrics.go#L170`.
@dpordomingo dpordomingo changed the title Make gitcollector fail if progress status could not be updated Make gitcollector fail if metric could not be updated Jul 12, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@dpordomingo