Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

Some changes to opentracing reported metrics #151

Closed
ajnavarro opened this issue Apr 11, 2018 · 3 comments
Closed

Some changes to opentracing reported metrics #151

ajnavarro opened this issue Apr 11, 2018 · 3 comments
Assignees
Labels
enhancement New feature or request

Comments

@ajnavarro
Copy link
Contributor

ajnavarro commented Apr 11, 2018

To improve the use of opentracing, we should do some minor changes:

  • Tags should only be used with data that can be used to filter between operations (per example, on analyze operation, we can add a tag with the output of IsResolved of the plan). Right now the query is set on a tag, move it to a span.Log()

  • On analyze and analyze_once add a log with the plan of the node that is being processed.

  • Be able to use the default jaeger environment variables instead of custom configuration. To do that, there is a tracer constructor on jaeger config package.

  • Remove spans from Merge and Update aggregation methods, they are really verbose and say almost nothing, and add the span to Eval.

  • Right now, we cannot follow the entire trace of a query because it is splitted into several parts with no relations between them; parse, analyze and the execution of the query itself. We must be able to trace at query level.

  • The tracer name must be configurable, not hardcoded to go-mysql-server (this can be done using JAEGER_SERVICE_NAME)

@ajnavarro ajnavarro added the enhancement New feature or request label Apr 11, 2018
@ajnavarro
Copy link
Contributor Author

ajnavarro commented Apr 11, 2018

What do you think about that @src-d/data-retrieval @smola @mcuadros ?

@smola
Copy link
Collaborator

smola commented Apr 11, 2018

@ajnavarro Sounds good. I think the most important part is that we can trace the execution phase. If we were able to track only execution (with a payload with the plan), that would be great. If other phases are there, that's ok.

@mcuadros
Copy link
Contributor

I will need to see in real-life, but at the end whatever is useful for you guys.

@kuba-- kuba-- self-assigned this Apr 12, 2018
@kuba-- kuba-- mentioned this issue Apr 16, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

5 participants