Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

Support DISTINCT and multiple expressions on aggregation functions #162

Closed
erizocosmico opened this issue Apr 20, 2018 · 2 comments
Closed
Labels
bug Something isn't working

Comments

@erizocosmico
Copy link
Contributor

erizocosmico commented Apr 20, 2018

According to MySQL documentation aggregation functions support DISTINCT clause and COUNT supports multiple expressions. We don't support neither.

I have been trying to implement the DISTINCT in a simple way by creating a DISTINCT aggregation node to pass to the aggregation functions instead but it's a bit complicated to do for aggregations this way so it ended up nowhere and this can't be done with query rewriting.

We should think more about how to implement this correctly.

Labeling as bug because right now it parses but produces wrong results.

@erizocosmico erizocosmico added the bug Something isn't working label Apr 20, 2018
@jlcanovas
Copy link

Just found this problem while using the tool and came to check if it was already reported. I see it was!

@erizocosmico
Copy link
Contributor Author

This is already implemented and on master

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants