Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

Proposal: add build flag to be able to use REGEXP statement with Oniguruma #341

Closed
ajnavarro opened this issue Aug 30, 2018 · 3 comments
Closed

Proposal: add build flag to be able to use REGEXP statement with Oniguruma #341

ajnavarro opened this issue Aug 30, 2018 · 3 comments
Assignees
@jfontan
Labels
enhancement New feature or request performance Performance improvements proposal proposal for new additions or changes

Comments

@ajnavarro
Copy link
Contributor

Go regular expressions are not as fast as they should. To make REGEXP statement faster, we can add the possibility of compile with Oniguruma regular expressions instead of Go ones.

Similar case here: src-d/enry#156
@ajnavarro ajnavarro added enhancement New feature or request performance Performance improvements proposal proposal for new additions or changes labels Aug 30, 2018
@jfontan jfontan assigned jfontan and unassigned jfontan Sep 5, 2018
@jfontan
Copy link
Contributor

jfontan commented Sep 5, 2018

Done in gitbase: src-d/gitbase#452

@jfontan jfontan closed this as completed Sep 5, 2018
@ajnavarro ajnavarro reopened this Sep 5, 2018
@ajnavarro
Copy link
Contributor Author

this is to use oniguruma regular expressions on REGEXP statement, not to use enry.

@jfontan jfontan self-assigned this Sep 5, 2018
@erizocosmico
Copy link
Contributor

Take into account that https://github.com/moovweb/rubex master is not usable and branch go1 should be used

@jfontan jfontan mentioned this issue Sep 6, 2018
Merged
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@jfontan jfontan

Labels
enhancement New feature or request performance Performance improvements proposal proposal for new additions or changes
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@jfontan @ajnavarro @erizocosmico