Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

Add support for binding parameters #428

Open
meyskens opened this issue Oct 9, 2018 · 4 comments
Open

Add support for binding parameters #428

meyskens opened this issue Oct 9, 2018 · 4 comments
Labels
empathy-sessions Issue filed as as part of empathy sessions feature proposal proposal for new additions or changes

Comments

@meyskens
Copy link

meyskens commented Oct 9, 2018

I am using the github.com/go-sql-driver/mysql MySQL driver for Go. When I try to execute a query containing a variable i get the error that it is not implemented yet.

Error 1047: command handling not implemented yet: 22
q, err := db.Query(`
	SELECT 
		COUNT(*)
	FROM
		commit_files
	NATURAL JOIN
		ref_commits
	WHERE
		ref_commits.ref_name = 'HEAD'
		AND ref_commits.history_index = 0
		AND commit_files.repository_id = ?
		AND commit_files.file_path NOT REGEXP '^vendor.*'
	`, repoID)
@erizocosmico
Copy link
Contributor

Yep, that's not implemented yet AFAIK

@meyskens
Copy link
Author

meyskens commented Oct 9, 2018

Then see this as a feature request 😉I could not find it listed here.

@ajnavarro ajnavarro added proposal proposal for new additions or changes feature labels Oct 9, 2018
@erizocosmico erizocosmico changed the title command handling Add support for binding parameters Oct 9, 2018
@erizocosmico erizocosmico self-assigned this Oct 19, 2018
@erizocosmico
Copy link
Contributor

erizocosmico commented Oct 19, 2018

After a little bit of investigation, turns out COM_STMT_PREPARE and COM_STMT_EXECUTE are not implemented in vitess.

I'm not sure if we want to do this and contribute it to vitess, give it's not a requirement for now in the OKRs. How should we proceed? @ajnavarro

More info:

@erizocosmico erizocosmico removed their assignment Oct 19, 2018
@ajnavarro
Copy link
Contributor

@erizocosmico we should focus on OKRs.

@smola smola added the empathy-sessions Issue filed as as part of empathy sessions label Oct 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
empathy-sessions Issue filed as as part of empathy sessions feature proposal proposal for new additions or changes
Projects
None yet
Development

No branches or pull requests

4 participants