Skip to content
This repository has been archived by the owner on Jan 28, 2021. It is now read-only.

Suppress build warning for oniguruma #623

Closed
kuba-- opened this issue Feb 25, 2019 · 1 comment
Closed

Suppress build warning for oniguruma #623

kuba-- opened this issue Feb 25, 2019 · 1 comment
Assignees
Labels
proposal proposal for new additions or changes

Comments

@kuba--
Copy link
Contributor

kuba-- commented Feb 25, 2019

Every time when we build mysql (and/or gitbase) with oniguruma you'll get an warning:

# github.com/src-d/gitbase/vendor/github.com/moovweb/rubex
chelper.c:161:43: warning: passing 'const OnigUChar *' (aka 'const unsigned char *') to parameter of type 'const char *' converts between pointers to integer types with different sign [-Wpointer-sign]
/usr/include/secure/_string.h:124:34: note: expanded from macro 'strncpy'

Because go binding for oniguruma is archived, we need to fork it to src-d/go-oniguruma first.
Keep in mind that only go1 branch is useful for us.

@kuba-- kuba-- added the proposal proposal for new additions or changes label Feb 25, 2019
@kuba-- kuba-- self-assigned this Feb 25, 2019
@kuba--
Copy link
Contributor Author

kuba-- commented Feb 27, 2019

it was done here: https://github.com/src-d/go-oniguruma
So the task now is to adopt a new rubex fork in mysql.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
proposal proposal for new additions or changes
Projects
None yet
Development

No branches or pull requests

1 participant