-
Notifications
You must be signed in to change notification settings - Fork 101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Python conventions improvements ideas #331
Comments
/cc @vmarkovtsev |
This is the current state of all our ML projects:
|
@vmarkovtsev thank you for the explanation! |
This seems sensible. We should add this already, since it's our current minimum.
Using
It can be a good recommendation for everyone though. |
I think that really helps to understand the code faster, and it should be a really very nice to have at least for "public" methods. Just as an example we started using type hinting in lookout-sdk and along with sphinx docstring makes the code easy to follow (example). |
The current status of python conventions is a bit poor. Here are some of the things that I think could be decided and that would help to improve consistency across python projects:
>=3.5
, they could be tested only on travis or using for exampletox
pip + requirements.txt
,pipenv
,poetry
(I personally likepoetry
as it also handles packaging and publishing)setup.py + twine
,poetry
virtualenvs
or maybe evenconda
?flake
, usage of other tools such asisort
for imports sortingThe text was updated successfully, but these errors were encountered: