Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update to go-1.13 #238

Closed
carlosms opened this issue Sep 10, 2019 · 3 comments · Fixed by #242
Closed

Update to go-1.13 #238

carlosms opened this issue Sep 10, 2019 · 3 comments · Fixed by #242
Assignees
Labels
enhancement New feature or request

Comments

@carlosms
Copy link
Contributor

carlosms commented Sep 10, 2019

Go 1.13 is out, according to our conventions we should update.

@dpordomingo dpordomingo mentioned this issue Sep 13, 2019
2 tasks
@dpordomingo dpordomingo self-assigned this Sep 16, 2019
@dpordomingo dpordomingo added the enhancement New feature or request label Sep 16, 2019
@dpordomingo
Copy link
Contributor

Do we want to use go1.13 error wrapping instead of current go-error?
Should we confirm it company-wide?

@carlosms
Copy link
Contributor Author

I would say yes, but it's something we can do later. Maybe we can open a new issue to src-d/guide to discuss it (as the convention is documented here https://github.com/src-d/guide/blob/master/engineering/conventions/go.md#error-handling)

@dpordomingo
Copy link
Contributor

I would say yes, but it's something we can do later. Maybe we can open a new issue to src-d/guide to discuss it (as the convention is documented here https://github.com/src-d/guide/blob/master/engineering/conventions/go.md#error-handling)

Good idea. Issue opened here src-d/guide#383

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants