Skip to content

Commit 5c9fa82

Browse files
committed
feat(slider): rename isDiscrete to discrete; hasMarkers to markers
BREAKING CHANGE: rename mdcSlider property isDiscrete to discrete, rename mdcSlider property hasMarkers to markers
1 parent 03ca89e commit 5c9fa82

File tree

3 files changed

+8
-8
lines changed

3 files changed

+8
-8
lines changed

bundle/src/components/slider/mdc.slider.directive.ts

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -201,7 +201,7 @@ export class MdcSliderDirective implements AfterContentInit, AfterViewInit, OnCh
201201

202202
_onChanges(changes: SimpleChanges, callValueAccessorOnValueChange = true) {
203203
if (this._initialized) {
204-
if (this.isChanged('isDiscrete', changes) || this.isChanged('hasMarkers', changes)) {
204+
if (this.isChanged('discrete', changes) || this.isChanged('markers', changes)) {
205205
for (let handlerInfo of this._interactionHandlers)
206206
// workaround for uspstream bug: https://github.com/material-components/material-components-web/issues/1429
207207
this._registry.unlisten(handlerInfo.type, handlerInfo.handler);
@@ -355,25 +355,25 @@ export class MdcSliderDirective implements AfterContentInit, AfterViewInit, OnCh
355355
* "Discrete slider" is a UX treatment, while having a step value is behavioral.</blockquote>
356356
*/
357357
@Input() @HostBinding('class.mdc-slider--discrete')
358-
get isDiscrete() {
358+
get discrete() {
359359
return this._discrete;
360360
}
361361

362-
set isDiscrete(value: any) {
362+
set discrete(value: any) {
363363
this._discrete = asBoolean(value);
364364
}
365365

366366
/**
367367
* Property to enable/disable the display of track markers. Display markers
368368
* are only supported for discrete sliders. Thus they are only shown when the values
369-
* of both hasMarkers and isDiscrete equal true.
369+
* of both markers and discrete equal true.
370370
*/
371371
@Input() @HostBinding('class.mdc-slider--display-markers')
372-
get hasMarkers() {
372+
get markers() {
373373
return this._markers;
374374
}
375375

376-
set hasMarkers(value: any) {
376+
set markers(value: any) {
377377
this._markers = asBoolean(value);
378378
}
379379

site/src/app/components/snippets/directives/snippet.elevation.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<div [mdcElevation]="elevation" [animateTransition]="animate" class="blox-elevation-surface">Elevated {{elevation}}dp</div>
33
<section>
44
<div mdcSlider aria-label="Change Elevation" mdcScrollbarResize
5-
minValue="0" maxValue="24" stepValue="1" isDiscrete hasMarkers [(value)]="elevation"></div>
5+
minValue="0" maxValue="24" stepValue="1" discrete markers [(value)]="elevation"></div>
66
<div mdcFormField>
77
<div mdcCheckbox>
88
<input mdcCheckboxInput type="checkbox" [(ngModel)]="animate"/>

site/src/app/components/snippets/directives/snippet.slider.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -2,7 +2,7 @@
22
<div>
33
<div mdcSlider aria-label="Select Value"
44
[(minValue)]="min" [(maxValue)]="max" [(stepValue)]="step"
5-
[isDiscrete]="discrete" [hasMarkers]="markers"
5+
[discrete]="discrete" [markers]="markers"
66
[(ngModel)]="value" [disabled]="disabled"></div>
77
</div>
88
<p>Customize slider:</p>

0 commit comments

Comments
 (0)