Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cap title length of srcbooks #207

Closed
nichochar opened this issue Aug 24, 2024 · 2 comments · Fixed by #212
Closed

Cap title length of srcbooks #207

nichochar opened this issue Aug 24, 2024 · 2 comments · Fixed by #212
Labels
good first issue Good for newcomers

Comments

@nichochar
Copy link
Contributor

nichochar commented Aug 24, 2024

Implement Title Length Validation for Srcbooks

Objective

Limit Srcbook titles (encoded as markdown h1) to a maximum length for design and pragmatic reasons.

Requirements

  1. Set max title length to N characters (proposed: N = 50 44)
  2. Implement validation at:
    • Import time
    • Client-side update in /srcbook view
    • Server-side update
@benjreinhart
Copy link
Contributor

We already have one area that caps this at 44 characters. I believe that was calculated based on the available space in the cards on the home page and also how it looks visually on the Srcbook page.

@nichochar
Copy link
Contributor Author

Edited initial description with 44.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants