Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

license should not be kept in lab directory with license.key name #131

Closed
hellt opened this issue Nov 16, 2020 · 0 comments · Fixed by #140
Closed

license should not be kept in lab directory with license.key name #131

hellt opened this issue Nov 16, 2020 · 0 comments · Fixed by #140

Comments

@hellt
Copy link
Member

hellt commented Nov 16, 2020

Currently, the clab doesn't allow to have different license files for different nodes/kinds, as it copies the license file to the lab directory - https://github.com/srl-wim/container-lab/blob/81e0f749835e25d6d1f0360b38f96a67b7f9b8f0/clab/file.go#L146

proposal is to copy the license file under the node directory explicitly, and mount it from there

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant