Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New Tabs and Language Options for CBSS Browse page #184

Open
wsalesky opened this issue Aug 21, 2024 · 3 comments
Open

New Tabs and Language Options for CBSS Browse page #184

wsalesky opened this issue Aug 21, 2024 · 3 comments

Comments

@wsalesky
Copy link
Contributor

@wlpotter @davidamichelson Did we make any decisions about the browse page? I seem to remember the default being browse by author? Do we need the different language tabs? Anything else?

@wlpotter wlpotter added the CBSS label Aug 27, 2024
@davidamichelson davidamichelson changed the title CBSS Browse page New Tabs and Langauge Options for CBSS Browse page Sep 6, 2024
@davidamichelson davidamichelson changed the title New Tabs and Langauge Options for CBSS Browse page New Tabs and Language Options for CBSS Browse page Sep 6, 2024
@davidamichelson
Copy link

davidamichelson commented Sep 6, 2024

Please make the following changes to https://dev.syriaca.org/cbss/browse.html

  • Remove the "sort" button in the paging buttons
  • Add the date slider above the results list (and below the alphabet buttons), and make it work (see issue about date slider not working currently in search results)
  • Change "Browse works cited by author" to "Browse Bibliography by Author"
  • Make the following changes to the tabs for the script choices
  • Add new tabs for
  1. Greek (using these letters Α-Ω for the tab) "Α-Ω" is in unicode so please use exactly these, not the latin A
  2. Cyrillic (using these letters А-Я for the tab) А-Я is in unicode so please use exactly these, not the latin A
  3. Hebrew (using these letters א-ת‎ for the tab) Due to Right to Left (א should display on the right of the dash
  4. Armenian (using these letters Ա-Ֆ for the tab)

Please order the tabs horizontally in this order with English on the far left and Syriac on the far right:

A-Z
А-Я
Α-Ω
Ա-Ֆ
א-ת‎
ا-ي
ܐ-ܬ

(I list them vertically here in the issue just so the order is clear, the github text box is freaking out about the list having multiple right to left languages in it).

Next, there are some issues with how the browse results are being filtered or sorted.

It looks like the current alphabetical filter is running on the first name rather than the last name. Can we fix that please? Please use:

Next it looks like the sorting by language is not working as expected. I will create a separate issue for that.

@davidamichelson
Copy link

Wow, now the RTL issue won't let me edit the box at all :)

So I am completing my thoughts from above here.

Next, there are some issues with how the browse results are being filtered or sorted.

It looks like the current alphabetical filter is running on the first name rather than the last name. Can we fix that please? Please use: /TEI/text/body/biblStruct/analytic/author/surname (first letter of surname text string)

Next it looks like the sorting by language is not working as expected. I will create a separate issue for that.

@wlpotter
Copy link
Contributor

just an fyi on the name sorting, not all the records will have forename and surname; e.g., https://dev.syriaca.org/cbss/35F77WHT. So I think prefer sort by tei:surname, but backup would be sort by tei:name

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants