Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make configs TOML-compatible #92

Open
EmilyGraceSeville7cf opened this issue Mar 19, 2022 · 3 comments
Open

Make configs TOML-compatible #92

EmilyGraceSeville7cf opened this issue Mar 19, 2022 · 3 comments

Comments

@EmilyGraceSeville7cf
Copy link
Contributor

EmilyGraceSeville7cf commented Mar 19, 2022

For instance instead of:

[eg-config]
examples-dir = ~/examples-dir
custom-dir = ~/my/fancy/custom/dir

write:

[eg-config]
examples-dir = "~/examples-dir"
custom-dir = "~/my/fancy/custom/dir"

Maybe it's just a documentation mistake and configs are already written in TOML.

@srsudar
Copy link
Owner

srsudar commented Mar 20, 2022

Hmm can you tell me a bit more about what taplo is? I'm not sure I understand what a JSON schema for taplo would mean.

I don't think that the documentation and configs are already written in TOML, though I might be mistaken. eg uses the ConfigParser package, which when I wrote it I believe I thought was the standard way of parsing various .ini and rc files.

@EmilyGraceSeville7cf
Copy link
Contributor Author

EmilyGraceSeville7cf commented Mar 21, 2022

JSON schema for taplo means that when I install taplo extension for VS Code I have suggestions for eg configs from JSON schema:

image

The problem with configs - they don't provide quoting for strings (which TOML requires). Please switch to another parser because the current one is for INI files. JSON Schema don't support INI files so it's better to use TOML. 😄

@srsudar
Copy link
Owner

srsudar commented May 30, 2022

Oh got it. Seems cool to have that kind of autocompletion, I agree. I'm a bit behind on PRs atm due to work stuff, but I'll take a look at this. I like this kind of integration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants