Allow user to connect by specifying either GUID or IP address. #3
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miquelmassot
added a commit
that referenced
this pull request
Oct 30, 2014
Allow user to connect by specifying either GUID or IP address.
|
Thanks for the contribution @pkok ! |
vbrebion
pushed a commit
to vbrebion/avt_vimba_camera
that referenced
this pull request
Sep 15, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The code allows for using either a GUID or IP address to connect to a camera (lines 103 -- 118 of
src/vimba_ros.cpp). However, because of the defaults given by the configuration file, IP address always has to be set after which the GUID if supplied (which is done by the configuration file) will be checked. These configuration variables do not really allow for sensible default values.This pull request sets the default values for
guidandip_addressto the empty string. By doing so, the software will look for user-specified values for these two values, and allows it when only one of the two are set. If both are set, both still have to be correct.