Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: calculate age based on modification date #146

Closed
AngryMaciek opened this issue Aug 18, 2024 · 3 comments
Closed

feat: calculate age based on modification date #146

AngryMaciek opened this issue Aug 18, 2024 · 3 comments
Assignees
Labels
enhancement New feature or request good first issue Good for newcomers @type/feature @type/new

Comments

@AngryMaciek
Copy link

It would be nice to have an option which could switch the mechanism of age calculation, rather then from object creation to last modification. That way we could easily catch stale PRs. Right now if the setting is 1w the following action would constantly label each PR older then a week every day (scheduled daily execution).

@srvaroa
Copy link
Owner

srvaroa commented Aug 19, 2024

Makes sense, to avoid behaviour changes I prefer to solve ir with a new condition (e.g. last-updated), but good idea anyway

@srvaroa srvaroa added enhancement New feature or request good first issue Good for newcomers labels Aug 19, 2024
@srvaroa
Copy link
Owner

srvaroa commented Sep 2, 2024

Hi @AngryMaciek I've pushed a draft PR for this #149 - I have to go AFK so I'll leave this here and give a final pass later.

Let me know if the config seems reasonable (the first two modified files in the diff are a sample and the documentation).

(if the at-least/at-most duration conditionals make sense I might add support for these in age too)

Cheers!

@srvaroa srvaroa self-assigned this Sep 2, 2024
@srvaroa
Copy link
Owner

srvaroa commented Sep 6, 2024

Released at v1.11.0 (now used in @master's default Dockerfile)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request good first issue Good for newcomers @type/feature @type/new
Projects
None yet
Development

No branches or pull requests

2 participants